Standardize "Ebooks" terminology in entry points (PP-3604) #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathangreen
commented
Jan 28, 2026
| } | ||
|
|
||
| /** This component renders a library's entrypoints as linked tabs. */ | ||
| export class EntryPointsTabs extends React.Component<EntryPointsTabsProps, {}> { |
Member
Author
There was a problem hiding this comment.
This line failed eslint with:
circulation-admin/src/components/EntryPointsTabs.tsx
17:76 error Don't use `{}` as a type. `{}` actually means "any non-nullish value".
- If you want a type meaning "any object", you probably want `object` instead.
- If you want a type meaning "any value", you probably want `unknown` instead.
- If you want a type meaning "empty object", you probably want `Record<string, never>` instead.
- If you really want a type meaning "any non-nullish value", you probably want `NonNullable<unknown>` instead @typescript-eslint/ban-types
Not related to any change I made, but maybe got picked up because I modified this file.
Update the entry point label mapping and tests to use "Ebooks" instead of "eBooks" to match the standardized terminology in the Formats facet from the groups feed.
jonathangreen
force-pushed
the
feature/standardize-ebooks-terminology
branch
from
ca8b50a to
6fb4fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
{}type) inEntryPointsTabs.tsxReferences